Open koppor opened 3 years ago
I'll view this as a bit of a mid-length project. Preliminarily I am looking at
Id
)Id
) -> replace with Comparator.andThen
or .reduce(Comparator::thenComparing)
-> removedComparator.comparingInt(String::length).reversed()
) -> removedand it seems that EntryComparator
and FieldComparatorStack
serve the same purpose.
Most of them are essentially unchanged in the last 8 years (i.e., they are pre-GitHub) so I'll take a look at modernizing the ones I believe need it. The changes should lead to a lot less code that is more readable (❤️ Java 8+) so I'd guess it is a one PR change.
Should the PR go here or in the JabRef/jabref
?
I'd guess it is a one PR change.
I fully agree.
Therefore I woud open the PR against JabRef/jabref
. Here, we collect PRs, which are suspended or take a veeeeeery long time to finish. This issue here is more a short-term one.
The
EntryComparator
does not call theFieldComparator
.Why?
Should be fixed. - At least JavaDoc should added referencing each other and explaining the differences.
Refs https://github.com/JabRef/jabref/pull/7708