search

koppor / jabref

Collection of simple for JabRef issues. Please submit PRs to https://github.com/jabRef/jabref/.
https://github.com/jabRef/jabref/
MIT License
8 stars 13 forks source link

Enable drag'n'drop of groups to new library #530

Closed koppor closed 1 year ago

koppor commented 2 years ago

grafik

rafatd commented 1 year ago

Mr Koppor,

I was attempting to work on this problem, which I eventually resolved. However, I ran into a minor issue. The problem is as follows: Whenever a library is created it does not get a root group at the same time, instead, a root group is only created for a library whenever "add group" button is used, which makes it quite complicated to drag'n'drop groups to it. I had to improvise by adding a root group into that library to be able to drop the dragged groups.

Please let me know if I should not do that? Or if there is another way to solve that issue.

Also on a side note: I know this was not asked but I thought it would be useful to also add the subgroups of the dragged groups. I think it makes more sense that was. Let me know if this solution is useful.

Please find bellow my PR link, let me know if you are happy with what I made. https://github.com/JabRef/jabref/pull/9460

Just to also confirm, I was not able to write tests for that, I do not think its possible, let me know if I am wrong.

Thanks.