Entry editor should focus entry selected in the main table

koppor / jabref

Collection of simple for JabRef issues. Please submit PRs to https://github.com/jabRef/jabref/.

https://github.com/jabRef/jabref/

MIT License

8 stars 13 forks source link

Entry editor should focus entry selected in the main table #541

Open koppor opened 2 years ago

koppor commented 2 years ago

When grouping is activated and a paper is removed from the current group, the main table changes the selection, but the entry editor does not update.

koppor commented 2 years ago

Minimal example:

% Encoding: UTF-8

@Article{test,
  author = {Second, Article},
}

@Article{,
  author = {First, Article},
}

@Comment{jabref-meta: databaseType:bibtex;}

@Comment{jabref-meta: grouping:
0 AllEntriesGroup:;
1 KeywordGroup:tagged_red\;0\;keywords\;red\;0\;0\;0\;0x8a8a8aff\;\;\;;
1 SearchGroup:not_tagged_red\;0\;NOT(keywords=red)\;0\;0\;1\;0x8a8a8aff\;\;\;;
}

grafik

Drag and drop Second to group tagged_red:

After dropping:

grafik

Thus, wrong article selected in main table:

grafik

koppor commented 2 years ago

sayan9112 commented 1 year ago

Hey, Can I work on this? @koppor

koppor commented 1 year ago

@sayan9112 Sorry for the late answer. If no one is assigned, you can work on this. I assume, you found another issue to work on.

atdushi commented 9 months ago

Is it still relevant? If drag and drop an article, it will be added to another group, but the old one will remain. @koppor

Unsaved Image 1

k3KAW8Pnf7mkmdSMPHz27 commented 9 months ago

@atdushi I don't know if this is still relevant, but I'd encourage you to use the provided example. It should be possible to create a .bib file and load it in JabRef based on that.

As I understand the original issue, the problematic behavior is that the BibEntry shown in the editor isn't the one selected in the maintable. The BibEntry that was first selected has been moved away from the nottaggedred group, because it is now in the red group, and is therefore no longer selected in the maintable, since it isn't visible.
As I understand your example, this is the intended behavior of JabRef and not a bug.

If you can confirm if the problematic behavior is still there, that would be appreciated! If it is still there, and you are interested in solving it, reproducing it will be the first step.

yuyan-z commented 7 months ago

Hi! I reproduced the given example and confirmed that this problem still exists. May I take this issue as my course project? I expect to finish it by December 9th. Thank you!

koppor commented 7 months ago

@yuyan-z We need to discuss internally whether this is really good first issue. The thing is that you understand much parts of JabRef's code to maybe change maybe 10 lines of code.

I would suggest to browse through https://github.com/orgs/JabRef/projects/3/views/3 to find a better suited issue. Maybe https://github.com/JabRef/jabref/issues/10506 is better to code?