search

koppor / jabref

Collection of simple for JabRef issues. Please submit PRs to https://github.com/jabRef/jabref/.
https://github.com/jabRef/jabref/
MIT License
8 stars 13 forks source link

Dropdown for file types at "Find Unlinked Files" should not contain .bib #547

Closed koppor closed 1 year ago

koppor commented 2 years ago

As user, I collect my papers as .pdf or .html, but not as .bib, because BibTeX is the meta data

grafik

Simone-Thai commented 1 year ago

Hi, could I be assigned to this issue?

Simone-Thai commented 1 year ago

Hi Koppor, I'm planning to remove the BibTeX option and add in both the HTML and TXT standard file types, I was wondering about your thoughts on this?

Simone-Thai commented 1 year ago

I've noticed ImportHandler doesn't currently check html files. There currently isn't a method to parse a html file in EnternalFilesContentImporter and there are no importers for html files, however there is a citaviXmlImporter which may be relevant to this issue. I believe that this is outside the scope of this issue, but I wanted a second opinion on this?

koppor commented 1 year ago

Hi Koppor, I'm planning to remove the BibTeX option and add in both the HTML and TXT standard file types, I was wondering about your thoughts on this?

This is OK. Selection of multiple file types should be possible.

Additionally, *.md, should also be possible as Markdown becomes more and more prominent

koppor commented 1 year ago

I've noticed ImportHandler doesn't currently check html files.

The file could just be linked without any other meta data.

however there is a citaviXmlImporter which may be relevant to this issue.

HTML is a a format with many options to put content in. There is no easy way to parse HTML. One could write a parser checking the <head> content of HTML. Contents such as title is standardized - and this could be read very easy. (See https://html.spec.whatwg.org/multipage/dom.html#metadata-content-2 for details)

For .txt, this is more complex.

koppor commented 1 year ago

In case a file type is not recognized at import, the name of the file (without extension) should be used as title in BibTeX.

Simone-Thai commented 1 year ago

I've added a markdown file option:

Screen Shot 2022-10-28 at 4 05 13 pm

So far I've been working in the UnlinkedFilesDialogViewModel class but are there other areas that I need to work on too?

Simone-Thai commented 1 year ago

Hi Koppor, I am planning to add an icon to the markdown file so I was wondering if you had any suggestions to go about this?

Simone-Thai commented 1 year ago

I've ended up adding a basic file icon to the dropdown, is this icon appropriate?

image
koppor commented 1 year ago

Yes, its good. I have no other Markdown icon in mind (and I did not google :p)