search

koppor / jabref

Collection of simple for JabRef issues. Please submit PRs to https://github.com/jabRef/jabref/.
https://github.com/jabRef/jabref/
MIT License
8 stars 13 forks source link

Unchecked "Do not ask again" does not work #566

Open koppor opened 2 years ago

koppor commented 2 years ago
  1. Reset JabRef preferences
  2. Restart JabRef
  3. Start Import:\ grafik
  4. Choose metaData.pdf from src\test\resources\pdfs grafik
  5. JabRef asks for "Remote services" grafik\ grafik
  6. Click "yes"
  7. Cancel the import grafik
  8. Import the PDF again (steps 3 and 4)
  9. Expected: Dialog appears. However, the PDF is parsed as is (and no dialog is appearing)\ grafik
DunkDoge commented 1 year ago

Hi, can I work on this issue? I'm in a uni group and we've been tasked with contributing to open source software

koppor commented 1 year ago

A huge discussion was going on at https://github.com/JabRef/jabref/pull/9291.

Decision:

Preferences: Radio-Button-Group for Grobid: enable grobid, disable grobid, always ask for confirmation (source: https://github.com/JabRef/jabref/pull/9291#issuecomment-1306143262)

(No "DoNotAskAgain" button)

Open point: Link to privacy statement. This can be ommitted in the PR.

hanachaari commented 1 year ago

Hi everyone ! I want to work on this issue.

hanachaari commented 1 year ago

I am changing Gorbid preferences section into a radio-button-group. But the text property could not be resolved. image I tried to add new labels, but I could not find the right folder in the project.

koppor commented 1 year ago

You are working on strings shown to the user. These strings are also localized, because JabRef supports localization. Please read on at https://devdocs.jabref.org/code-howtos/localization.html for that topic. I think, this will help you to resolve the issue.

hanachaari commented 1 year ago

The link was helpful. I added the strings to "JabRef_en.properties" and the problem was resolved.

hanachaari commented 1 year ago

I have solved the issue and proceeded to create a merge request. So first I pulled the changes made in the origin repo (https://github.com/JabRef/jabref) and incorporated them into my repository. Without modifying any code I tried to run it but had an error in a file I never checked before. image Shouldn't it run without errors when first pulled from the main branch of the origin repository?

hanachaari commented 1 year ago

I want to confirm that we will omit the "do not ask again" checkbox as mentioned in this comment https://github.com/koppor/jabref/issues/566#issuecomment-1370332527 @koppor . From a UX perspective, it would be better to keep it.

koppor commented 1 year ago

Question answered at https://github.com/JabRef/jabref/pull/9801#issuecomment-1524050565.

hanachaari commented 1 year ago

I have updated my branch with commits and updates made in the original repository . When I run it, I had this error. image I checked the imported files, indeed they don't exist in "src\main\java\org\jabref\logic\exporter\ModsExporter.java" image but rather in src-gen\main\java\org\jabref\logic\importer\fileformat\mods image

koppor commented 1 year ago

Execute "clean" and then "classes" task in gradle:

image

SUPWEZZ commented 9 months ago

Hi, I would like the work on the issue, please assign it to me if possible!

colinldbd commented 9 months ago

Hi, is this issue be worked on? If not, can you please assign this issue to me? I'm a new contributor and learning how to contribute to open source projects.

koppor commented 8 months ago

@SUPWEZZ This time, you were quicker than @colinldbd, so I assign @SUPWEZZ

koppor commented 8 months ago

@SUPWEZZ This is a really hard issue, because it is not that much about implementation, but understanding what the current request is. Please go through the discussions, especially https://github.com/JabRef/jabref/pull/9801#issuecomment-1524050565

Maybe, it would help to create a MADR document for the options to structure the possibilities.

SUPWEZZ commented 8 months ago

Hi @koppor, sorry about that I'm a little confused. I just noticed I was being unassigned in two issues, but I would like to request one issue. I would like to ask compare it with "Import by id: cancel doesn't really cancel the request #10508" and "uncheck Do not ask again" Which issue is more suitable for beginners?

koppor commented 8 months ago

@SUPWEZZ Both are more harder. For an easy one, I would recommend you to volunteer for https://github.com/JabRef/jabref/issues/10569

koppor commented 8 months ago

@SUPWEZZ Based on the comment at https://github.com/JabRef/jabref/issues/10569#issuecomment-1777864845, I assign you here. - Not that I did not an unassignment, you can choose whatever you want. The only condition is that the issue is not already assigned to someone else.

Now, please focus on this one. Follow my recommendation at https://github.com/koppor/jabref/issues/566#issuecomment-1772238345, which I gave you 5 days ago.