Open koppor opened 2 years ago
Proposal: A however on the label "user-specific file directory" should show the username.
Hi @koppor , Soft Eng intern here. I'd like to take a stab at this issue if it's possible. Thanks.
@jackmcardle99 I assigned you. Should be three lines of code.
When reading https://github.com/JabRef/jabref/issues/9990, there should also be a proper tool tip on "LaTeX file directory". Maybe you can work on that too @jackmcardle99?
Will get started on both issues this weekend @koppor
Hello, I'm a new contributor, and I will carefully read the contribution guidelines. Could you please assign this issue to me? @ThiloteE U6591996 W-10
As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.
Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.
In JabRef, when a user is not logged in, there's a need to retrieve the username from the operating system. However, which one should be used?
Username: This is the unique identifier of the user within the system. For instance, in the Windows operating system, the username could be "john_doe," while in the Linux operating system, it might be "jane_smith."
User's Home Directory: This is the main folder in the file system associated with the user, usually identified by their username. For instance, in the Windows operating system, the main directory might be "C:\Users\john_doe," whereas in the Linux operating system, it could be "/home/jane_smith."
Which of these should JabRef use to identify the user when they are not logged in? @koppor @ThiloteE Thank you so much for your help.
I do my change in Display_username branch, before my pull request, just wanna check if my change satisfy the issue's requirement:
Now the username is displayed:
I do several changes in the org.jabref.gui.libraryproperties.general.
src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesView.java:
org/jabref/gui/libraryproperties/general/GeneralProperties.fxml
src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesViewModel.java
@koppor @ThiloteE
In JabRef, when a user is not logged in, there's a need to retrieve the username from the operating system. However, which one should be used?
Username: This is the unique identifier of the user within the system. For instance, in the Windows operating system, the username could be "john_doe," while in the Linux operating system, it might be "jane_smith."
User's Home Directory: This is the main folder in the file system associated with the user, usually identified by their username. For instance, in the Windows operating system, the main directory might be "C:\Users\john_doe," whereas in the Linux operating system, it could be "/home/jane_smith."
Which of these should JabRef use to identify the user when they are not logged in? @koppor @ThiloteE Thank you so much for your help.
In JabRef, when a user is not logged in, there's a need to retrieve the username from the operating system. However, which one should be used?
JabRef already handles this. It uses the log in user name of the current user. As you outlined, this is different from the laptop / PC / workstation / ... one uses.
The shown graphics looks like a debug version.
Please implement as follows:
Implement a hover on user-specific file directory. If the mouse is on hower, JabRef displays: user: {username}, host: {hostname}
.
Please DO NOT modify the field content. This is the place, where the user configures their directory.
This is the presentation of this pull request. I am still confused about the log in user, because even though I have read the documentation, I still cannot find where to log in JabRef.
In JabRef, when a user is not logged in, there's a need to retrieve the username from the operating system. However, which one should be used?
JabRef already handles this. It uses the log in user name of the current user. As you outlined, this is different from the laptop / PC / workstation / ... one uses.
The shown graphics looks like a debug version.
Please implement as follows:
Implement a hover on user-specific file directory. If the mouse is on hower, JabRef displays:
user: {username}, host: {hostname}
.Please DO NOT modify the field content. This is the place, where the user configures their directory.
@koppor @ThiloteE
You cannot log in to JabRef, since JabRef is not a multi-user distributed application, but just a desktop application for the current os user to use. But multiple users are working with JabRef, every user has probably his own home directory. It is also not of importance, what username JabRef should use, if no user is logged in, because no user could use JabRef, when not logged in to a computer running JabRef. Still I don't get your question.
Please don't use the issue description to present screenshots of your code changes, but put this all into your Pull Request, since this clutters the issue discription with a lot of information that is about your PR and not about the original issue.
There went sthg wrong, when i tried to resolve merge conflicts with in a PR, sorry for that.
It is unclear, which JabRef key is used there.
*Update