search

koppor / jabref

Collection of simple for JabRef issues. Please submit PRs to https://github.com/jabRef/jabref/.
https://github.com/jabRef/jabref/
MIT License
8 stars 13 forks source link

Explicit conflict marker detection #629

Open koppor opened 2 years ago

koppor commented 2 years ago

Fixes https://github.com/JabRef/jabref/issues/9167

WIP, because the parsing architecture is a bit complicated here.

We cannot "just" read the whole file, because it could be very slow when reading large data bases.

koppor commented 1 year ago

Two implementation ideas:

  1. Dive into the grammar and add "exception" paths for conflict markers
  2. Do a pre-reading of the file and check for conflict markers
  3. Spawn a parallel thread checking for conflict markers. If the normal reading thread returns, with an error, check what the checking thread said.

Think, we could go for 2 even though file loading might be slower?! -- https://www.amitph.com/java-read-write-large-files-efficiently/