add methods to MarcXMLParser

koppor / jabref

Collection of simple for JabRef issues. Please submit PRs to https://github.com/jabRef/jabref/.

https://github.com/jabRef/jabref/

MIT License

8 stars 14 forks source link

add methods to MarcXMLParser #647

Closed Luggas4you closed 11 months ago

Luggas4you commented 1 year ago

Add new methods to the class MarcXMLParser, refs https://github.com/JabRef/jabref-issue-melting-pot/issues/101

ToDo:

putIssue:

[x] pages
[x] volume and number
[x] series and journals stored in different tags

putThesisDesription:

[x] thesis

putConferenceDetail:

[x] proceedings (In progress)

Mandatory checks

[ ] Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
[ ] Tests created for changes (if applicable)
[ ] Manually tested changed features in running JabRef (always required)
[ ] Screenshots added in PR description (for UI changes)
[ ] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
[ ] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

calixtus commented 1 year ago

Looks good.

Luggas4you commented 1 year ago

I looked into proceedings today. However, I could not find a unique identifier. It's often in the title, but I couldn't find a specific tag. In tag 111 you find informations about meetings, but I don't think they are needed: Meeting name, location of meeting and date of meeting. I implemented a method and set the meeting name for 'EVENTITLE' and the location of the meeting for adress. However the location will be overwritten once the publisher information gets parsed.

Questions: Is the 'EVENTTITLE' field for such meetings? Is the location of the meeting important? Are there other EntryTypes which include a meeting?

calixtus commented 1 year ago

At the very end, it's always a bit of guessing, I think. I believe some fields are not filled anyways if the book is just a conference proceeding.

calixtus commented 1 year ago

Tbh I totally dislike those 100% code coverage tests. Especially here: is it really desirable to have no help page or is this a deficit? 100% coverage is not the target and static code analysis is a trojan horse for bad design.

Luggas4you commented 1 year ago

Tbh I totally dislike those 100% code coverage tests. Especially here: is it really desirable to have no help page or is this a deficit? 100% coverage is not the target and static code analysis is a trojan horse for bad design.

You right, this test does not make any sense. There is no test needed as the GetHelpPage is empty() or not.

Luggas4you commented 11 months ago

The PR which had been merged into JabRef: https://github.com/JabRef/jabref/pull/10144