search

koppor / plantuml

A LuaLaTeX package for PlantUML in LaTeX
https://koppor.github.io/plantuml/
LaTeX Project Public License v1.3c
55 stars 10 forks source link

Changed file extension for including LaTeX diagrams to align with PlantUML #29

Closed Geronymos closed 1 year ago

Geronymos commented 1 year ago

Closes https://github.com/koppor/plantuml/issues/28

Plantuml changed the file extension for diagrams exported to $\LaTeX$ from .latex to .tex in this PR. This change breaks this package since it includes the generated .latex file.

With this PR the package now includes the new .tex file.

p.s. I was the one submitting the change in plantuml. Sry for the breakage everyone :)

koppor commented 1 year ago

Thank you for the update! Would it be possible to add a CHANGELOG entry, too? https://github.com/koppor/plantuml/blob/main/CHANGELOG.md

I know, you have to add the [unreleased] section. However, it would help me to craft a new release soon.

Geronymos commented 1 year ago

I would say this is a Change because of the updated plantuml dependency and the changed file extension. Furthermore it is a breaking change and therefore results in a new MAJOR version, since this change is not compatible for people running an old version of plantuml. Would you agree on this?

koppor commented 1 year ago

We are still at 0 at the major version, thus we can do breaking changes in minor versions, too.

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

You don't need to introduce the new version number, just "unreleased". Maybe, there is some other PR changeing something before the next release.

Geronymos commented 1 year ago

Sorry for missing that. Is everything else right?