search

koraktor / steam-condenser

A multi-language library for querying the Steam Community, Source, GoldSrc servers and Steam master servers
https://koraktor.de/steam-condenser
Other
359 stars 65 forks source link

[Ruby] Rcon authenticated in GoldSrc #223

Closed jpalumickas closed 11 years ago

jpalumickas commented 11 years ago

Hello,

In steam-condenser/servers/goldsrc_server.rb on method rcon_auth never set @rcon_authenticated to true, so we cannot get extended players list.

I have an idea how to check if authenticated or not. Maybe we can instantly make rcon_exec('status') on rcon_auth and if it's not rescued to RCONNoAuthException, then we can set @rcon_authenticated = true

koraktor commented 11 years ago

There's no way to check if a RCON "connection" to a GoldSrc server is authenticated, that's why GameServer#update_players accepts a parameter for the RCON password. That way you can authenticate if you need the additional player information.

jpalumickas commented 11 years ago

I tried and there was no extended information, so this is a bug. I gave to you an idea, how to check :)

koraktor commented 11 years ago

Are you sure this is caused by not sending the RCON request at all? Please enable logging / $DEBUG and check the output.