search

koraktor / steam-condenser

A multi-language library for querying the Steam Community, Source, GoldSrc servers and Steam master servers
https://koraktor.de/steam-condenser
Other
356 stars 67 forks source link

toString methods #235

Open ZeroOne3010 opened 10 years ago

ZeroOne3010 commented 10 years ago

In the Java version, please add proper toString methods to some key classes (such as GameAchievement, SteamGame and GameStats) in order to facilitate testing and prototyping.

ZeroOne3010 commented 10 years ago

I've created pull request number 10 for this one.

gcoelho commented 10 years ago

@koraktor Is this issue closed? Need any additional help here?

koraktor commented 10 years ago

No, this is still open, although koraktor/steam-condenser-java#10 has been merged, but there are plenty of other classes that could use some improvement here.

And additionally, the other implementations could use the same enhancements.

gcoelho commented 10 years ago

Ok, I will work on this issue. Any classes you want me to take a look first?

koraktor commented 10 years ago

Well, it's would be most useful to have it for the "front-end" classes, like the servers, GameLeaderboard and inventories.

gcoelho commented 10 years ago

@koraktor What code format standard do you use? I am asking to use the same while adding this methods. If possible, can you share this config file to be imported?

koraktor commented 10 years ago

@gcoelho There's no codystyle.xml or similar, but there's a CONTRIBUTING file for each implementation and you should follow the conventions in there.

gcoelho commented 10 years ago

Ok, thanks! :+1:

I just did a commit for GameLeaderboard and Servers. Inventories classes don´t have a test class so I will create some tests too on a future commit.

If you want to take a look: gcoelho/steam-condenser-java@d8379f558d9d27a1a99735dcd70050939a18f0b3

I wiil keep working on this issue to include Inventories.