search

koraktor / steam-condenser

A multi-language library for querying the Steam Community, Source, GoldSrc servers and Steam master servers
https://koraktor.de/steam-condenser
Other
356 stars 67 forks source link

PHP - Monolog 2.x compatability? #329

Open zack6849 opened 4 years ago

zack6849 commented 4 years ago

Hi There!

I wanted to use your project in a newer laravel project, which requires monolog 2.x

Are there any plans to update to 2.x, or are you opposed to a PR to do such a thing?

I did make a fork for this, i also removed the phpdoc generator from composer require dev, as it was causing issues and their readme suggested strongly that you don't use composer to install it for that very reason.

Thoughts?

Thanks!

koraktor commented 4 years ago

If you can provide a PR that adapts the code to Monolog 2 and it does not radically change either the code or the requirements (PHP Version etc.) I‘ll merge it.

PS: Another PR for that phpdoc change will also be happily accepted if you can add the appropriate information about that change.

zack6849 commented 4 years ago

Hm, it looks like all monolog 2.x releases needs php 7.2 or higher.

Are you opposed to having a php 7.2 or higher branch of this? php 5.x is pretty much deprecated at this point, not to say the library shouldn't support it, but is it necessary to hold it back for legacy compatibility when someone can simply download an older revision?

koraktor commented 4 years ago

I think this would be unproblematic if it doesn‘t require huge code changes. And even if it does it might be worth having a look.

zack6849 commented 4 years ago

I've gone ahead and created a PR for this

I ran tests, and got one failure, but the same failure happens on the current code, i'm unsure if it's a version compatibility issue, or if it's something that's always existed (I don't have a php 5.x installation to test with :) )

Rodhin commented 3 years ago

Hi there, any updates on this? I see that the PR is still pending and nothing has changed since May 5.

zack6849 commented 3 years ago

Hi Rodhin, I've been busy and haven't changed anything recently, the latest updates are on the PR itself, here: https://github.com/koraktor/steam-condenser-php/pull/24