search

korapp / plasma-nordvpn

Simple Plasma Applet for the official NordVPN linux client
GNU General Public License v3.0
19 stars 1 forks source link

Feature request: option to consider plasmoid inactive when VPN is disconnected #17

Closed ian-h-chamberlain closed 1 year ago

ian-h-chamberlain commented 1 year ago

Thanks for this plasmoid, it's super convenient!

From looking at the source https://github.com/korapp/plasma-nordvpn/blob/master/plasmoid/contents/ui/NordVPN.qml#L143 https://github.com/korapp/plasma-nordvpn/blob/master/plasmoid/contents/ui/main.qml#L17

it appears the plasmoid would only be considered "inactive" (i.e. can be moved to overflow) if the nordvpn service is not running at all. Would it be possible to add a configuration option to consider the status inactive whenever the VPN is disconnected? nordvpn status still exits 0 when disconnected as long as the daemon is running, but I'd ideally like to push the tray icon to overflow when it's not connected.

Thanks again! If you'd prefer I can probably try to dive in and implement it myself, but I don't have much experience writing QML / plasma applets

korapp commented 1 year ago

Sure. I even thought about it during the initial development, but the idea was lost somewhere.