zca_whiten is using :resize instead of :view

koraykv / unsup

Some unsupervised learning modules using Torch

86 stars 36 forks source link

zca_whiten is using :resize instead of :view #18

Closed soumith closed 10 years ago

soumith commented 10 years ago

at several places, zca_whiten is using :resize, while this works in practice, the correct way would be :view or :reshape as :resize by definition can be destructive when it wants to.

koraykv commented 10 years ago

sure, pr? :)

soumith commented 10 years ago

Fixed in https://github.com/koraykv/unsup/commit/c69ae3f25b4367c84931a6a78fba09f1ad31d628 Verified that that zca unit tests pass.