search

kordamp / gm

Gum is a Gradle/Maven/JBang wrapper written in Go
Apache License 2.0
59 stars 2 forks source link

Suggestion: use `gum` instead of `gm` #12

Closed littleli closed 4 years ago

littleli commented 4 years ago

Why would I suggest that? Reason is quite simple. On Windows with Powershell, ie. all current versions of Windows gm is something else. It's Get-Members command.

Technically user can use gm.exe explicitly which resolves the problem, but it's a quite weird. As far as I know gum or gum.exe does not conflict with anything common.

Note: I'm working on scoop package manifest and I use scoop shim which is a workaroudn for this. Unpleasant fact of this solution is, that on Windows shim is not your program directly but intermediary binary.

manikmagar commented 4 years ago

Oh, and when using Oh-My-Zsh git aliases, it conflicted with gm alias for git merge -

image
aalmiray commented 4 years ago

I'd have to give this more thought. On one side the project is young so a rename is still possible without causing so much disruption. However I like gm and it does not conflict in other platforms as far as I'm aware.

Note that the official name of the project is "Gum" and that the snapcraft page also uses "gum" as the app name gm was reserved and I couldn't use it.

What about this, producing both gm.exe and gum.exe and let consumers decide which one they want to use?

littleli commented 4 years ago

@aalmiray There is a PR in a review that I submitted for Scoop package manager. You can check my solution there.

aalmiray commented 4 years ago

@littleli Great! FWIW goreleaser allows setting up scoop -> https://goreleaser.com/customization/scoop/

littleli commented 4 years ago

You can decide to go with your own bucket. In my opinion it limits a bit user experience, because user have to manipulate buckets before use. After checking source code of goreleaser, it does not support shims yet, so user will still face the naming issue above.

aalmiray commented 4 years ago

@littleli Got it. If gum can be added to main Scoop then the better. I'm thinking in releasing 0.4.0 this weekend.

littleli commented 4 years ago

@aalmiray PR with scoop package was merged.

aalmiray commented 4 years ago

Awesome! Thank you 😄