search

kordamp / jsilhouette

JSilhouette provides additional shapes for Java applications
Apache License 2.0
43 stars 10 forks source link

Contribution: Copyright information #5

Open thejeed opened 2 years ago

thejeed commented 2 years ago

Hi there,

my company would like to contribute some squircle-related new forms to the project. Before we open a PR, I'd like to ask how to put the author's information into the added sources. We want to show my colleague as the author and our company as the entity contributing the effort. So, in which form would you like us to do that?

Kind regards,

David

aalmiray commented 2 years ago

Hi David,

Thank you for reaching out. Authorship is expressed with the @author javadoc tag at the class definition. However besides authorship we'd have to discuss license and copyright. The project uses Apache-2.0 as its license, if this is OK for your team and company then we can proceed. Next is copyright, at the moment all files list me (Andres Almiray) as copyright holder because well, I wrote all the code. Here we have a few options:

  1. you, tour colleagues, and your company retain authorship no matter what.
  2. your company retains copyright. This will require updating the license templates to reflect that fact (copyright belongs to the authors, not just one individual)
  3. OR your company transfers copyright to me.

Item 1. is a given. Item 2. is perhaps the less intrusive way for all parties to continue forward. Item 3. might require your legal department to be involved just to dot all the Is and cross all the Ts. Moreover a Contributor License Agreement (CLA) may or may not be needed.

Additionally, I can add a CONTRIBUTORS.md file listing all contributors/authors besides having authors appear on file headers.

Let me know your thoughts about these options.

thejeed commented 2 years ago

Hi Andres,

thanks for the explanation. I'd like to keep it just as simple for you and us, as possible. It's our intention to contribute under ASL 2.0 and the way you mentioned, we'll transfer the copyright to you. If you want us to sign a CLA, that will be fine for us, as well. We'll check it with our lawyer, but I don't see an impediment.

It would be nice to have a CONTRIBUTORS.md added, indeed.

aalmiray commented 2 years ago

Hi David,

I've updated the project settings with the following:

Please let me know if any changes are required from your POV.

thejeed commented 2 years ago

Hi Andres, that's fine for us, thank you. I just created PR #9.