search

kordamp / kordamp-gradle-plugins

A collection of Gradle plugins
https://kordamp.org/kordamp-gradle-plugins/
Apache License 2.0
138 stars 25 forks source link

Compatibility issue with the recent Spring Boot Gradle plugin #505

Closed jerzykrlkroche closed 1 year ago

jerzykrlkroche commented 1 year ago

Kordamp plugin suite won’t work well with a recent Spring Boot Gradle plugin.

Kordamp seems to be indirectly including an ancient Spring version, like this:

|    |    +--- project :licensing-gradle-plugin
|    |    |    \--- gradle.plugin.com.hierynomus.gradle.plugins:license-gradle-plugin:0.16.1
|    |    |         \--- com.mycila:license-maven-plugin:3.0
|    |    |              +--- org.springframework:spring-core:3.1.3.RELEASE

This seems a bit tricky to fix, because there’s a new com.mycila:license-maven-plugin:4.2.rc3, which doesn’t depend on Spring libs any more. But the gradle.plugin.com.hierynomus.gradle.plugins:license-gradle-plugin:0.16.1 is the most recent version available.

I don't have a good idea, what'd be the right place to put the fix - any thoughts?

aalmiray commented 1 year ago

I think you can workaround this issue by setting the spring dependency directly in settings.gradle. You must set it as a classpath dependency.

The proper fix would be to update the dependency in the license plugin, likely triggering a 0.17.0 release.

aalmiray commented 1 year ago

Fixed with https://github.com/kordamp/kordamp-gradle-plugins/commit/a77e3dd16d9e9c6f2ec07d7f149d4c7939225776