Closed emacdona closed 9 years ago
Hi Ed, I've reviewed your patch and looks OK. However there are no tests for it. Could you please provide at least one? Also note that master has moved a few commits ahead so please rebase before resubmitting the patch. I've checked locally and all your changes will be applied without any conflicts :smile:
Hi, we gave it a try during last night's hackergarten and found two minor things:
the version number makes it hard to push the artefact to local maven repo and use it in a build. and the license function need a trick so that groovy can sort out which one (license plugin or pubish) to use.
diff --git a/gradle.properties b/gradle.properties
index 0912f8a..3e794f0 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -1,4 +1,4 @@
-version = 0.2.0.SNAPSHOT
+version = 0.2.0-SNAPSHOT
group = org.kordamp
sourceCompatibility = 1.7
targetCompatibility = 1.7
diff --git a/gradle/publish.gradle b/gradle/publish.gradle
index dc3494a..528fb4c 100644
--- a/gradle/publish.gradle
+++ b/gradle/publish.gradle
@@ -48,7 +48,7 @@ def pomConfig = {
url 'https://github.com/aalmiray/markdown-gradle-plugin'
inceptionYear '2013'
licenses {
- license {
+ license ([:]){
name 'The Apache Software License, Version 2.0'
url 'http://www.apache.org/licenses/LICENSE-2.0.txt'
distribution 'repo'
after that we got a
the number of constructors during runtime and compile time for org.kordamp.gradle.markdown.Conversion do not match. Expected -1 but got 1
and had no clue how to digg deeper ;-)
Sorry for the delay. I should have some free time this weekend. I’ll write some tests after rebasing and then resubmit.
Thanks! -ed
On Oct 31, 2014, at 5:08 AM, Andres Almiray notifications@github.com wrote:
Hi Ed, I've reviewed your patch and looks OK. However there are no tests for it. Could you please provide at least one? Also note that master has moved a few commits ahead so please rebase before resubmitting the patch. I've checked locally and all your changes will be applied without any conflicts
— Reply to this email directly or view it on GitHub https://github.com/aalmiray/markdown-gradle-plugin/pull/10#issuecomment-61234760.
Any news? I really like to see #7 fixed. Ideally before the release of Smack 4.1 which will be in a few weeks.
I think #15 applies all these changes plus a few fixes.
I believe this addresses the following issue: https://github.com/aalmiray/markdown-gradle-plugin/issues/7