kordamp / pomchecker

🦉 Maven POM syntax checker
Apache License 2.0
60 stars 8 forks source link

Resolved version conflict with maven-core #8

Closed jruaux closed 1 year ago

jruaux commented 1 year ago

maven-core 3.8.6 depends on maven-resolver-* 1.6.3. This should solve the AbstractMethodError (issue #6)

aalmiray commented 1 year ago

I think pomchecker recently upgraded to Maven 3.8.7

Going back to resolver 1.6.3 feels weird to me. I wonder if there's something else that can be done to fix the underlying issue.

jruaux commented 1 year ago

I added a dependency for maven-resolver-impl which was the one conflicting with other maven-resolver-* dependencies. Hopefully that does it.

aalmiray commented 1 year ago

Were you able to test it locally?

aalmiray commented 1 year ago

FWIW the Gradle plugin may need an update as well https://github.com/kordamp/pomchecker/tree/master/pomchecker-gradle-plugin

jruaux commented 1 year ago

Yes I tested locally and it works

aalmiray commented 1 year ago

Thanks! 😄

jruaux commented 1 year ago

FWIW the Gradle plugin may need an update as well https://github.com/kordamp/pomchecker/tree/master/pomchecker-gradle-plugin

Does the gradle plugin need to have the same dependencies as pomchecker-core? Not sure how this works for maven-resolver-impl

aalmiray commented 1 year ago

Just posted an update https://github.com/kordamp/pomchecker/commit/224da687a70b2f6fe9cbcdab7acfa30ac8613205