search

kordan / moodle-mod_surveypro

The surveypro module per moodle
13 stars 15 forks source link

Removed other string concatenation (m403) #893

Closed kordan closed 11 months ago

kordan commented 11 months ago

This specific PR for MOODLE_403_STABLE because I am going to increase the surveypro version to cache new strings

stronk7 commented 11 months ago

And... shouldn't master also get the changes? I mean, we have changed the strings in 401, 402 and 403 (3 separate PRs), but master still has the old, unchanged, strings, isn't it?

kordan commented 11 months ago

mmmhhh not sure I got your suggestion. Didn't you merge lang improvement in #889?

stronk7 commented 11 months ago

Yes, and #889 was cherry picked to 401, 402 and 403.

But here, you're providing more lang changes, only for 403, in #892 for 402 and in #891 for 401.

And my question is... what happens with these lang changes and master?

kordan commented 11 months ago

You are right. Executing: diff -ur --exclude='.git' /Applications/MAMP/htdocs/m402/mod/surveypro /Applications/MAMP/htdocs/m403/mod/surveypro (where the semantic is trivial) I get: --- /Applications/MAMP/htdocs/m402/mod/surveypro/version.php 2023-12-14 19:01:35 +++ /Applications/MAMP/htdocs/m403/mod/surveypro/version.php 2023-12-14 19:00:33 @@ -26,6 +26,6 @@

$plugin->component = 'mod_surveypro'; $plugin->maturity = MATURITY_BETA; -$plugin->version = 2023120104; -$plugin->release = '4.3.2'; +$plugin->version = 2023120102; +$plugin->release = '4.4dev'; $plugin->requires = 2023100900;

I will immediately create a PR to increase the version for master only. THANKS!

kordan commented 11 months ago

896