Unified the acquisition of $edit at the beginning of the file

kordan / moodle-mod_surveypro

The surveypro module per moodle

13 stars 15 forks source link

Closed kordan closed 10 months ago

kordan commented 10 months ago

This branch has been built on top of wrong_condition_in_manage_editbutton to let it pass GHA.

In the frame of this fix I also:

verified the presence of "Blocks editing on" in each page (it was missing from report pages)
moved setadditionalparams close to the other set* methods in classes/reportbase.php
reordered methods in a report/attachments/classes/report.php

This PR needs wrong_condition_in_manage_editbutton to work properly.

It should be merged to MOODLE_401|402|403_STABLE too.

stronk7 commented 10 months ago

It seems that we are facing some conflicts here...

kordan commented 10 months ago

Conflict fixed. Reday again in about one hour.

stronk7 commented 10 months ago

Merged and cherry-picked to 401, 402 & 403.

Ciao :-)

kordan commented 10 months ago

THANK YOUUUUUU