Some early init changes

koreader / android-luajit-launcher

Android NativeActivity based launcher for LuaJIT, implementing the main loop within Lua land via FFI

MIT License

131 stars 84 forks source link

Some early init changes #316

Closed pazos closed 3 years ago

pazos commented 3 years ago

Block until permissions are granted before launching the LuaJIT vm.
Don't raise errors if runtime permissions were rejected (can happen). Just show a toast and finish the activity.
Annotate all methods called from lua as @WorkerThread
Continue migration to kotlin extensions.
Reworked mandatory permissions

I refactored a bit the C/JNI code. Probably some stuff in jni_helper.c can be abstracted away, but I'm fine as is and it seems to work fine :)

This change is

pazos commented 3 years ago

Somehow I killed the 3 dots animation while uncompressing assets. Need to figure out why.

pazos commented 3 years ago

Somehow I killed the 3 dots animation while uncompressing assets. Need to figure out why.

Extracting assets in the main thread blocks the animation. We still need to call android.extractAssets() from Lua. It is blocking on that thread (NativeThread) but leaves the UIThread responsive to show the animation.

pazos commented 3 years ago

wops, pushed the button without changing the squash message :/