search

koreader / android-luajit-launcher

Android NativeActivity based launcher for LuaJIT, implementing the main loop within Lua land via FFI
MIT License
131 stars 85 forks source link

Add Onyx SDK lights controller, Onyx Note Air2, & Onyx Nova Air C #372

Closed bb010g closed 2 years ago

bb010g commented 2 years ago

Follow-up to #342. When classes or methods don't exist, KOReader doesn't crash, addressing koreader/koreader#8584.

Tested on an Onyx Nova Air C. cc/ @bezmi @Galunid

This change is Reviewable

pazos commented 2 years ago

@bb010g: thanks for your contribution!

Please keep refactoring (sorting, device ids simplification) separated from new features.

You can make a different PR with the refactor. It will be merged soon. Then you can rebase this PR on top of master with only the bits of logic you've added.

bb010g commented 2 years ago

@pazos The reformatting commit has been split out, and this branch's commits are on top of the latest master. Does the reformatting commit still need to be split out to a separate PR? These commits are atomic, so you shouldn't need to squash them while merging.

pazos commented 2 years ago

Does the reformatting commit still need to be split out to a separate PR?

Nope. Works for me as is. :+1:

pazos commented 2 years ago

hey @bb010g, could you take a look at the review and update the PR?

There're some users that might benefit from the new driver waiting in https://github.com/koreader/koreader/issues/8482.

It doesn't need to be soon :tm: , though.

If you're busy elsewhere I can take care of it ;)

pazos commented 2 years ago

Done, thanks for your work!