search

koreader / android-luajit-launcher

Android NativeActivity based launcher for LuaJIT, implementing the main loop within Lua land via FFI
MIT License
131 stars 85 forks source link

Strict #379

Closed pazos closed 2 years ago

pazos commented 2 years ago

Changes in debug buildvariant

  1. remove leakcanary: only covers JVM code and didn't report a single memory leak in the last 2-3 years.
  2. reduce strictmode penalty log categories to those that are actually useful: 2.1 slow calls: slow code paths on UiThread 2.2 potential leaks: closable objects and activity context

FWIW: I use this paired with the removal of https://github.com/koreader/koreader/blob/master/platform/android/llapp_main.lua#L24-L25 to test platform changes locally.

Also interesting when building for targetSdk > 28 is add nonsdk usage. We're clear ATM (targetSdk:30). Device drivers using reflection might trigger some logs but those need to be handled at the system/firmware level.

This change is Reviewable