search

koreader / android-luajit-launcher

Android NativeActivity based launcher for LuaJIT, implementing the main loop within Lua land via FFI
MIT License
131 stars 85 forks source link

Unbreak 64bit builds #390

Closed NiLuJe closed 2 years ago

NiLuJe commented 2 years ago

The MultiDexApplication stuff changed in ABI 21+, which breaks if we use minSdk 21...

But, apparently, we can build with an NDKABI > minSdk, so, do that ;p.

(c.f., https://github.com/koreader/koreader/issues/9632#issuecomment-1280781035)

This change is Reviewable

pazos commented 2 years ago

The unfortunate chain of events is:

  1. Added support for 64 bit builds on this repo a couple of years ago
  2. Enabled D8 to save a few KBs a few months later
  3. D8 requires a "desugaring" library.
  4. The desugaring library requires multidex support.

Here we are. Maybe for 200kb doesn't worth the hussle and we can get rid of multidex + desugaring?

In any case, LGTM

NiLuJe commented 2 years ago 
2. Enabled D8 to save a few KBs a few months later

3. D8 requires a "desugaring" library.

4. The desugaring library requires multidex support.

Here we are. Maybe for 200kb doesn't worth the hussle and we can get rid of multidex + desugaring?

I have no clue what any of these things are ;o).

pazos commented 2 years ago

I have no clue what any of these things are ;o).

Me too.

But I know what they do: magic to strip a few kb out of the apk.

After a quick skim of various opensource apps I think we're fine with this PR alone

could you remove instead of comment?