search

koreader / android-luajit-launcher

Android NativeActivity based launcher for LuaJIT, implementing the main loop within Lua land via FFI
MIT License
131 stars 85 forks source link

update to use NDK 23c #419

Closed benoit-pierre closed 1 year ago

benoit-pierre commented 1 year ago

The API level is now encoded in the toolchain executable names, and can be used in place.

Additionally, rework jni/luajit/mk-luajit.sh so each architecture has its own build directory (no need to clean when switching architecture). Note: the patches are applied to each build directory, not the original source checkout.

Bump minimum SDK version to 18 in build.gradle: the NDK version 23c minimal supported version is 16, but our builds only really work on 18 and above.

This change is Reviewable

poire-z commented 1 year ago

Can you merge it ? So @benoit-pierre can go on with his other PRs ? edit: unless you're still thinking about OTA/deprecation and better not bump stuff until you've done with the thought of course :)

benoit-pierre commented 1 year ago

This would allow me to update the base PR, and check the CI builds correctly, even if we wait for a new point release before merging it.

benoit-pierre commented 1 year ago

Wait, never mind, the (base) CI build does no create an APK, and luajit-launcher is a submodule of the main repo…