koreader / android-luajit-launcher

Android NativeActivity based launcher for LuaJIT, implementing the main loop within Lua land via FFI
MIT License
132 stars 84 forks source link

Remove support for legacy/deprecated methods #425

Closed pazos closed 2 months ago

pazos commented 1 year ago

This change is Reviewable

pazos commented 2 months ago

Also pinging @hugleo for a review.

pazos commented 2 months ago

not really sure what you mean by idiomatic Kotlin but lgtm

return if (x) 
    true
else
    false

instead of

if (x)
    return true
else
    return false

And a few other things: string templates, null checks via let ...