search

koreader / android-luajit-launcher

Android NativeActivity based launcher for LuaJIT, implementing the main loop within Lua land via FFI
MIT License
132 stars 84 forks source link

Onyx Tab Ultra Color support #431

Closed hugleo closed 8 months ago

hugleo commented 1 year ago

Add support to Onyx Tab Ultra Color

This change is Reviewable

pazos commented 1 year ago

Hey, thanks for the patch.

Color devices need to specify that too, so won't loose color when being treated as EinkDevices.

See https://github.com/koreader/android-luajit-launcher/blob/master/app/src/main/java/org/koreader/launcher/device/DeviceInfo.kt#L686

hugleo commented 1 year ago

Hey, thanks for the patch.

Color devices need to specify that too, so won't loose color when being treated as EinkDevices.

See https://github.com/koreader/android-luajit-launcher/blob/master/app/src/main/java/org/koreader/launcher/device/DeviceInfo.kt#L686

Bu it's already doing in my patch:

EinkDevice.ONYX_TAB_ULTRA_C -> true

pazos commented 1 year ago

ap, sorry.

I didn't catch it after a quick skim :p

All good then :)

pazos commented 10 months ago

@hugleo: I would like to merge this one, too. Please remove the draft flag :)

hugleo commented 10 months ago

Can be merged. Unfortunately no official build support for lights at the moment :( See : https://github.com/koreader/android-luajit-launcher/pull/436 for more information.