koreader / android-luajit-launcher

Android NativeActivity based launcher for LuaJIT, implementing the main loop within Lua land via FFI
MIT License
132 stars 84 forks source link

Fix running on android x86_64 #433

Closed hugleo closed 11 months ago

hugleo commented 1 year ago

It is necessary to load from the /system/lib64 directory, as this is where libraries like libm.so are located. Failure to do so will result in a crash of koreader.


This change is Reviewable

NiLuJe commented 1 year ago

There's a slightly more elegant variant in @benoit-pierre's branch, FWIW (https://github.com/benoit-pierre/koreader/blob/bpierre/subprojects/packagefiles/luajit-launcher/android-x86_64.patch)

hugleo commented 11 months ago

superseded by https://github.com/koreader/android-luajit-launcher/pull/441

NiLuJe commented 11 months ago

@hugleo: Feel free to mark your PRs as ready when you feel they're up to review, as I tend to just skip over drafts entirely when I'm short on time ;).

hugleo commented 11 months ago

@NiLuJe Sure. I got some for onyx ultrac by I'm waiting for 3.5 firmware (currently beta) to be released stable for proper tests/implementation.