search

koreader / android-luajit-launcher

Android NativeActivity based launcher for LuaJIT, implementing the main loop within Lua land via FFI
MIT License
132 stars 84 forks source link

Fix native orientation for device rotation #438

Closed hugleo closed 11 months ago

hugleo commented 11 months ago

Following the doc: android:screenOrientation="nosensor" explicitly disabled the automatic rotation of the screen android:screenOrientation="portrait" for portrait mode only android:screenOrientation="landscape" for landscape mode only

Removing these lines should allow the app to rotate based on the device's orientation.

I do tests with the native orientation of my device until I disabled app optimization to see the behavior like on a real android. Then I see that Koreader even when my device is in landscape mode it's only starts in portrait mode. Moving the device in circle does not cause Koreader to change its orientation. I can only change it manually by clicking the bottom menu buttons.

I believe Koreader should adjust the orientation when I physically move the hardware device.

Btw, if the current behavior is intentional, it doesn't matter to me since I don't use the function and that's perfectly fine like is today. I just tested it on Android 11.

This change is Reviewable

NiLuJe commented 11 months ago

if the current behavior is intentional

It is, because as you found out, we currently don't handle system gyro events ;).

pazos commented 11 months ago

@hugleo: please see https://www.mobileread.com/forums/showpost.php?p=4176423&postcount=5 and the next response from u/NiLuJe

We can't disable "nosensor" without a fully coherent rotation interface first. Then, when a proper rotation exists in the frontend, we can disable "nosensor" here and apply it programatically when the program is started, unless the user wants to follow gyro.