Reverted cutout and fix rotations

[hugleo]

This change is 

[hugleo]

Wondering why the changes for Android 14 don't work for me after I merged the changes with the checks and then I went to logging.

09-24 09:50:34.558 20926 20926 V Android_Version: onAttachedToWindow Android version is: 33 09-24 09:50:34.595 20926 20926 V Android_Version: surfaceChanged Android version is: 33 09-24 09:50:34.649 20926 20959 V Android_Version: getScreenWidth Android version is: 33 09-24 09:50:34.649 20926 20959 V Android_Version: getScreenHeight Android version is: 33

It is because my device is Android 13. DUH, DUH, DUH. I feel so dumb. That Xiaomi version screen really tricks me out."

Now the discussion about Android 14 doesn't make any sense since I actually have an Android 13 device.

@pazos Should I then apply my working changes to Android 13 then since I simulate the problem now on a real device?

Oh boy....

[pazos]

@hugleo: sorry for the delay.

two nitpicks and this can be merged.

Please add a log statement in the new condition, too. Use exactly the same string, so logs provide the same feedback in all android versions.

Please fix https://app.codacy.com/gh/koreader/android-luajit-launcher/pullRequest?prid=12685762

[hugleo]

@pazos nitpicks addressed

[jospalau]

This broke the screen for my Xiaomi. I don't read on the phone. Just letting you know. MIUI 14 too.

I am using the patch I used to use previously to the original fix that this is reverting to add the missing height.

[hugleo]

Do you have a screenshot of the problem?

[jospalau]

Sure.

[hugleo]

If you rotate to landscape in KOReader options and then back to portrait, does the problem go away?

[hugleo]

Also tell which device model

[jospalau]

No. In landscape mode the cut is on the right side.

[hugleo]

This device has a hole at the top just like mine. The black bar is supposed to fill the hole and should be drawn at the top. However, on yours, it is being drawn at the bottom. Unless, of course, you have a rotation configured like the picture below, this should be the normal behavior.

[jospalau]

I have it by default but I don't know why the order of the icons is different than in yours.

I think I know what you mean but I want it full screen like the rests of the apps.

Previous code reverted and the patch makes it work: local screen = require("android").screen screen.height = screen.height +90

[hugleo]

I have it by default but I don't know why the order of the icons is different than in yours.

I think I know what you mean but I want it full screen like the rests of the apps.

Previous code reverted and the patch makes it work: local screen = require("android").screen screen.height = screen.height +90

Your default setting is correct; in my case, I intentionally changed it. Your black bar should be at the top for this rotation mode.

[jospalau]

It is not a problem to be honest. Just curious. Thanks