search

koreader / android-luajit-launcher

Android NativeActivity based launcher for LuaJIT, implementing the main loop within Lua land via FFI
MIT License
132 stars 84 forks source link

fix native libraries search path #441

Closed benoit-pierre closed 11 months ago

benoit-pierre commented 11 months ago

Cf. https://github.com/koreader/koreader/issues/10533.

This change is Reviewable

NiLuJe commented 11 months ago

but are you sure they have to be excluded?

Yep, see the comments, the dynamic loader will bounce you if you try ;).

hugleo commented 11 months ago

Here the /lib/lib commit: https://github.com/koreader/android-luajit-launcher/commit/64caed00259bb23b789f2a8051e77efa9bcde9cc

An here the lib commit https://github.com/koreader/android-luajit-launcher/commit/9c95c44cdfe462dbe5f259daf7867cb2fa1719f5

benoit-pierre commented 11 months ago

Here the /lib/lib commit: 64caed0

An here the lib commit 9c95c44

Going back further: 7d0c1fcc2a1811af43ac42b8db76ca1c2268fb06

So /lib was already there, no idea why. The canonical directory is /system/lib on 32bits and /system/lib64 for 64bits, with the possible addition of /vendor/lib / /vendor/lib64.

I checked with the oldest available emulator image for x86 (API level 10, Gingerbread), and /system/lib is already used, no /lib.

Without a clear example of "broken Chinese ROMs or something", I would stick to the default.