search

koreader / android-luajit-launcher

Android NativeActivity based launcher for LuaJIT, implementing the main loop within Lua land via FFI
MIT License
130 stars 83 forks source link

Tolino Shine 4 support #457

Closed mergen3107 closed 1 month ago

mergen3107 commented 8 months ago

C.f., #410

This change is Reviewable

mergen3107 commented 8 months ago

There's no lua code to tweak here. What needs to be done is

  1. create a device definition for the TOLINO_SHINE_4.
  2. make sure the device isn't catched in the TOLINO superdevice.
  3. tweak TolinoRootController to include the sysfs path (lines highlighted on my previous comment). Put the new case at the top of the if/else branch, so it fallbacks to the same branch as it does now)
  4. assign the proper Lights and EPD drivers to the new device TOLINO_SHINE_4.
  5. Build a test APK.

@pazos I attempted steps 1-4. Please let me know if these are OK, so I can go an build the apk.

mergen3107 commented 8 months ago

2. make sure the device isn't catched in the TOLINO superdevice. I wasn't really sure about this one, so for the EPD Controller there are now TOLINO and TOLINO_SHINE_4 with the latter being a first outstanding Tolino device.

pazos commented 8 months ago

I attempted steps 1-4. Please let me know if these are OK, so I can go an build the apk.

Thanks, they're ok for testing. I'm not sure if the EPD impl is going to be worse than no implementation at all, but lets ask for feedback first.

hugleo commented 8 months ago

I think that will do it, you need build a new apk

mergen3107 commented 8 months ago

@hugleo Thanks for the review! I posted the new apk here: https://github.com/koreader/android-luajit-launcher/issues/410#issuecomment-1870488873 I've been updating it on Yandex.Disk, but the link stays the same.