search

koreader / android-luajit-launcher

Android NativeActivity based launcher for LuaJIT, implementing the main loop within Lua land via FFI
MIT License
130 stars 83 forks source link

Test tooltip #461

Closed hugleo closed 6 months ago

hugleo commented 7 months ago

tool-tip

This change is Reviewable

pazos commented 7 months ago

I'm not sure if the reason to make the tooltip a part of the dialog is to show the tooltip over the main program. In that case could you share a screenshot?

If not please build the tip as part of testactivity

hugleo commented 7 months ago

If not please build the tip as part of testactivity

Much better, thanks!

pazos commented 6 months ago

@hugleo: sorry, I forgot about this PR.

Could you rebase on top of master?

hugleo commented 6 months ago

@hugleo: sorry, I forgot about this PR.

Could you rebase on top of master?

there