search

koreader / android-luajit-launcher

Android NativeActivity based launcher for LuaJIT, implementing the main loop within Lua land via FFI
MIT License
130 stars 83 forks source link

Energy Ereader Pro HD support #466

Closed hugleo closed 1 month ago

hugleo commented 7 months ago

Commercial name of product: energy ereader pro hd Android version: 4.2.2 Driver(s) that work: Lights (only dim, the device has no warmth): Tolino root Tolino Ntx E-ink: Rockchip RK3026

Manufacturer: energy_sistem Brand: energy_sistem Model: energy ereader pro hd Device: energy_ereader_prohd Product: energy_ereader_prohd Hardware: rk30board Platform: rk3026

This change is Reviewable

pazos commented 7 months ago

Thanks, @hugleo!

I'm afraid we cannot add support for this device. Its android version is less than our minimum.

I keep a branch with the last supported version plus new devices. See https://github.com/koreader/koreader/issues/10614#issuecomment-1872595129

I wouldn't mind to keep it updated with new devices.

Gabriel85 commented 6 months ago

Well, I told you that support for old Android versions is important... This device could be great for at least another 5 years as long there is software support and the battery, doesn't break.

hugleo commented 6 months ago

Well, I told you that support for old Android versions is important... This device could be great for at least another 5 years as long there is software support and the battery, doesn't break.

The code can be added in the @pazos branch. But I think one needs to build the apk manually.

Gabriel85 commented 6 months ago

Well, I told you that support for old Android versions is important... This device could be great for at least another 5 years as long there is software support and the battery, doesn't break.

The code can be added in the @pazos branch. But I think one needs to build the apk manually.

Thats good! But that version has some bugs and KOReader is (thankfully) a rather quickly developing project and works very well even on old devices. And given that manufactures almost exclusively used ancient Android version until recently, probably the majority of devices which have ever been manufactured are running Android 4.4 or older. So I am hoping that at least no further changes about the minimum API level will occur anytime soon!

NiLuJe commented 6 months ago

So I am hoping that at least no further changes about the minimum API level will occur anytime soon!

Nope.