Closed jkl16 closed 4 months ago
Since complexity check is failing, should I split out EPD and light changes to a separate PRs?
Nah, that check seems kind of dumb, at least in the context of this PR.
Added Lights & Warmth driver implementing getting & setting values, however setting is not enabled since it requires root.
I'm not very fan of this. It would be better to use an Intent to launch the native dialog used by the system, if something like this exists. Gestures won't work but at least the dialog would be useful to change levels.
Until now all drivers rely on our own widget, so we need a little change to make possible to call external widgets instead.
What do you think, @jkl16?
In the device that I own, brightness & warm levels can only be controlled from native Android notification panel. It looks as on the following photo:
The panel can be accessed when running KOReader at any time by pulling it down from the top edge. From UX perspective that seems good enough, so maybe there is no need to implement that part at all. The biggest issue is the fact that the notification panel gesture collides with KOReader top menubar.
From UX perspective that seems good enough, so maybe there is no need to implement that part at all.
Better not indeed.
Then based on the discussion I removed all lights related code from the branch.
The biggest issue is the fact that the notification panel gesture collides with KOReader top menubar.
You can setup KO top menu to be activated only when tapping and use the swipe gesture to activate system menu.
I have provided more details in https://github.com/koreader/android-luajit-launcher/issues/477
This change is