koreader / android-luajit-launcher

Android NativeActivity based launcher for LuaJIT, implementing the main loop within Lua land via FFI
MIT License
130 stars 83 forks source link

Update luajit to match koreader luajit version #490

Closed hugleo closed 2 months ago

hugleo commented 2 months ago

This change is Reviewable

Frenzie commented 2 months ago

Was updated in https://github.com/koreader/koreader-base/pull/1828

hugleo commented 2 months ago

@benoit-pierre , @Frenzie Can we bump android-luajit-launcher on koreader already?

Frenzie commented 2 months ago

Were we specifically waiting to do that due to gradle changes or something? If there's a specific reason not to bump it I either missed it or forgot about it.

pazos commented 2 months ago

It is safe to bump

hugleo commented 2 months ago

Mostly because of this: https://github.com/koreader/koreader/issues/11723#issuecomment-2083360146

benoit-pierre commented 2 months ago

The koreader/koandroid:0.8.1-20.04 docker image has everything needed, so we can bump.

Frenzie commented 2 months ago

The next release in that context is 2024.04 which I tagged mere hours later. I didn't want to risk any delays in case something didn't work. I think the image should be fine but if not I'll fix it (or @benoit-pierre will, since he has this habit of being incredibly fast, or in any case available when I'm not).

Frenzie commented 2 months ago

Also GH has this habit of not showing new replies immediately.