search

koreader / contrib

Collection of non-official plugins designed for KOReader
GNU Affero General Public License v3.0
36 stars 8 forks source link

New optional sdr location #19

Open mergen3107 opened 1 year ago

mergen3107 commented 1 year ago

Hi @Hzj-jie ,

There is an ongoing development of the new centralized sdr folder location: https://github.com/koreader/koreader/pull/10132

Just letting you know, in case you would like to update your FindHistory plugin.

Hzj-jie commented 3 months ago

Sorry, I totally missed this thread. If my understanding is correct, the new location is configurable. Does it mean setting the home as koreader/ would mitigate the change?

Frenzie commented 3 months ago

Pinging @hius07 (since I don't know if you follow this repo)

mergen3107 commented 3 months ago

Most probably koreeader/docsettings/ , but I don't think it should be set as Home. Home is where all the books are available to browse and open, for example, in Books/

Hzj-jie commented 3 months ago

Yes, I am trying to understand if the functionality is totally broken or if there is a way to workaround it. And by default, the locations are still side-by-side with books, right?

Frenzie commented 3 months ago

The default hasn't changed.

I imagine you could work around it (but I'm not entirely sure what it is :-) by reading the relevant location setting or something.

hius07 commented 3 months ago

We can choose between 3 locations of books metadata: book folder (default), koreader/docsettings, koreader/hashdocsettings. Changing the setting doesn't change the location of previously opened books. This plugin cannot retrieve the book path from two new locations.

hius07 commented 3 months ago

Now the path to the book is stored in its sdr file as doc_path.