search

koreader / contrib

Collection of non-official plugins designed for KOReader
GNU Affero General Public License v3.0
41 stars 8 forks source link

analog clock plugin #2

Closed jperon closed 3 years ago

jperon commented 3 years ago

As is, it integrates MoonScript. It would be possible to "pre-compile" .moon files to .lua and get rid of the moonscript directory and moonscript.lua.

I don’t think insert_menu is necessary for it, as it’s already handled in clock.moon (l. 42-43).

This change is Reviewable

Frenzie commented 3 years ago

It would be possible to "pre-compile" .moon files to .lua and get rid of the moonscript directory and moonscript.lua.

Why not both? Moonscript is easily installed using luarocks so it hardly seems necessary to bundle the whole thing.

jperon commented 3 years ago

In fact, I think the best way would be to integrate only the pre-compiled .lua files in this repository, with the Readme directing users to https://github.com/jperon/clock.koplugin for issues. This would keep the "released" version here, simple (to install) & small (without moonscript dependency), and the "source" there. Any thoughts ?

Frenzie commented 3 years ago

I see no problem with simply referring back to the moonscript source in the plugin's README file and perhaps a little comment at the top of the file too.

jperon commented 3 years ago

Just force-pushed the changes.

Frenzie commented 3 years ago

Cool, thanks!

Hzj-jie commented 3 years ago

Thank you.