search

koreader / crengine

This is the KOReader CREngine fork. It cross-pollinates with the official CoolReader repository at https://github.com/buggins/coolreader, in case you were looking for that one.
70 stars 45 forks source link

lvfntman: fix `LVFontGlobalGlyphCache::removeNoLock` #532

Closed benoit-pierre closed 10 months ago

benoit-pierre commented 11 months ago

The cache size was not updated when removing the last item.

Potential impact: negligible, between 64 and 316 bytes on each book opening after the first one, resulting in a ~1% reduction in usable cache size after opening 17 books.

This change is Reviewable

poire-z commented 11 months ago

I remember you mentionned at https://github.com/koreader/crengine/pull/506#issuecomment-1418279289:

some inefficiencies in the font manager greatly increase loading times on some of my EPUBs (by a factor of ~7)

I guess this PR is not that - but has that already comes in?

benoit-pierre commented 11 months ago

I remember you mentionned at #506 (comment):

some inefficiencies in the font manager greatly increase loading times on some of my EPUBs (by a factor of ~7)

I guess this PR is not that - but has that already comes in?

No, this is this patch.