search

koreader / crengine

This is the KOReader CREngine fork. It cross-pollinates with the official CoolReader repository at https://github.com/buggins/coolreader, in case you were looking for that one.
70 stars 45 forks source link

lvfntman: fix harfbuzz related memory leak on quit #534

Closed benoit-pierre closed 10 months ago

benoit-pierre commented 11 months ago

This change is Reviewable

poire-z commented 11 months ago

"memory leak on quit" sounds like the best memory leaks :) Why chase them ? Just to get them out of the way to catch the other ones? Or some other reason?

NiLuJe commented 11 months ago

It makes Valgrind reports tedious to parse, making finding meaningful leaks that much more annoying ;).

benoit-pierre commented 11 months ago

"memory leak on quit" sounds like the best memory leaks :) Why chase them ? Just to get them out of the way to catch the other ones? Or some other reason?

Well, technically, leaks on dlclose.

It makes Valgrind reports tedious to parse, making finding meaningful leaks that much more annoying ;).

This.

I'm down to the expected 32 bytes (freetype memory object) in a lot of cases.