koreader / crengine

This is the KOReader CREngine fork. It cross-pollinates with the official CoolReader repository at https://github.com/buggins/coolreader, in case you were looking for that one.
70 stars 45 forks source link

Uplift German hyphenation patterns #549

Closed zwim closed 8 months ago

zwim commented 9 months ago

Well, I was lazy. The last update was 9 months ago. ;) Maybe this PR will find its way into 2023.12?

Happy new year and a peaceful Christmas for all!!!


This change is Reviewable

Frenzie commented 9 months ago
cr3gui/data/hyph/German.pattern:36780: parser error : Comment not terminated 
<!--
See: http://projekte.dante.de/Trennmuster/WebHome

^
cr3gui/data/hyph/German.pattern:36780: parser error : Start tag expected, '<' not found

^

Happy new year and merry Christmas (a bit early ;-)!

poire-z commented 8 months ago

Sorry, forgot about this PR. Given the initial christmas enthusiasm and broken XML, I thought it would better wait for the new year sobriety :) Dunno if it's safe to bring it with the crengine fix bump for the coming up stable :/

Frenzie commented 8 months ago

The changes are very minor. Whatever would be better or worse are probably just some edge cases.

poire-z commented 8 months ago

So, merging & bumping ?

Frenzie commented 8 months ago

Let's do it. You can blame me if someone complains Rindfleischetikettierungsüberwachungsaufgabenübertragungsgesetz is suddenly no longer correctly hyphenated. ;-D