search

koreader / crengine

This is the KOReader CREngine fork. It cross-pollinates with the official CoolReader repository at https://github.com/buggins/coolreader, in case you were looking for that one.
70 stars 45 forks source link

Update French.pattern #553

Closed cramoisi closed 6 months ago

cramoisi commented 7 months ago

Hello there ! As requested by @poire-z, one change to deal with some rare cases of l-l at the end of a line.

This change is Reviewable

poire-z commented 7 months ago

Thanks ! Any thought about my previous "issue" with neu-ros-ciences at https://github.com/koreader/crengine/pull/157#issuecomment-946173478 ?

cramoisi commented 7 months ago

Yup I forgot this one. Will do it tomorrow :)

Le mar. 16 janv. 2024 à 17:46, poire-z @.***> a écrit :

Thanks ! Any thought about my previous "issue" with neu-ros-ciences at #157 (comment) https://github.com/koreader/crengine/pull/157#issuecomment-946173478 ?

— Reply to this email directly, view it on GitHub https://github.com/koreader/crengine/pull/553#issuecomment-1894122038, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVXMMZJTW452KZJUH4SUN3YO2VETAVCNFSM6AAAAABB4Q2KJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUGEZDEMBTHA . You are receiving this because you authored the thread.Message ID: @.***>

cramoisi commented 7 months ago

Yop, I forgot how to add a change to an update :) I add <pattern>neu5ro5s6ciences</pattern> ; can you see it ?

poire-z commented 7 months ago

Thanks!

<pattern>neu5ro5s6ciences</pattern>

Not familiar with all things hyph patterns and how they work, but shouldn't we try to match for neuroscien* so to also do the right thing with neuroscientifique ?

cramoisi commented 7 months ago

Yup !

Le jeu. 8 févr. 2024 à 15:01, poire-z @.***> a écrit :

Thanks!

neu5ro5s6ciences

Not familiar with all things hyph patterns and how they work, but shouldn't we try to match for neuroscien* so to also do the right thing with neuroscientifique ?

— Reply to this email directly, view it on GitHub https://github.com/koreader/crengine/pull/553#issuecomment-1934184748, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVXMM57QXVRCDVLBYKPVRTYSTLFNAVCNFSM6AAAAABB4Q2KJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUGE4DINZUHA . You are receiving this because you authored the thread.Message ID: @.***>

poire-z commented 6 months ago

Gentle ping :) (My reading of "Les neuroscientifiques à l'époque de Churchill" is on hold since a few months ago, and I'm eager to finish it :)

cramoisi commented 6 months ago

that should do the trick.

poire-z commented 6 months ago

Thank you!