search

koreader / crengine

This is the KOReader CREngine fork. It cross-pollinates with the official CoolReader repository at https://github.com/buggins/coolreader, in case you were looking for that one.
70 stars 45 forks source link

Add typography rules for Russian #559

Closed dmalinovsky closed 5 months ago

dmalinovsky commented 5 months ago

Russian typography prohibits having one and two letter words hanging at the end of the line.

There are many Russian resources discussing this, I've linked one of the better known ones.

If anyone knows if this is true for Ukrainian and Belarusian as well, please let me know.

This change is Reviewable

dmalinovsky commented 5 months ago

@poire-z, can you please use this PR instead? My old one had a missing bracket — not sure how did it pass the checks...

poire-z commented 5 months ago

Oh, it's you who did this PR :) I just fixed that (editing directly on Github web and commiting to master, first time for me), at the same time you made that PR :) Was worried I messed up :)

Your first PR is already merged, too late. I fixed you error directly with https://github.com/koreader/crengine/commit/e498c1e4455567cea70a3c2b9e89ee736d25de16.

dmalinovsky commented 5 months ago

Thank you, @poire-z! I'll close this one then.

poire-z commented 5 months ago

I'm also removing a trailing space, which shows out in red in git console: image

Fine with you if I also make your comments aesthetically aligned & consistent ?: image

dmalinovsky commented 5 months ago

Fine with you if I also make your comments aesthetically aligned & consistent ?:

Yes, please do. I made that PR in Github editor, and it wasn't the best idea.