Closed benoit-pierre closed 2 months ago
Does shfmt ask for ${var}
regardless if it's necessary or not?
shellcheck
you mean? Yes, since we're using --enable=require-variable-braces
.
No, I didn't mean shellcheck since it's more of a stylistic choice. There are many situations where they're unequivocally necessary and shellcheck catches most or possibly all of those. I seem to have forgotten that we enabled that.
Fix issues in shell scripts picked up by base
.ci/lint_script.sh
when running it locally with the crengine submodule checked out.This change is![Reviewable](https://reviewable.io/review_button.svg)