search

koreader / crengine

This is the KOReader CREngine fork. It cross-pollinates with the official CoolReader repository at https://github.com/buggins/coolreader, in case you were looking for that one.
70 stars 45 forks source link

lint: shell scripts #576

Closed benoit-pierre closed 2 months ago

benoit-pierre commented 2 months ago

Fix issues in shell scripts picked up by base .ci/lint_script.sh when running it locally with the crengine submodule checked out.

This change is Reviewable

Frenzie commented 2 months ago

Does shfmt ask for ${var} regardless if it's necessary or not?

benoit-pierre commented 2 months ago

shellcheck you mean? Yes, since we're using --enable=require-variable-braces.

Frenzie commented 2 months ago

No, I didn't mean shellcheck since it's more of a stylistic choice. There are many situations where they're unequivocally necessary and shellcheck catches most or possibly all of those. I seem to have forgotten that we enabled that.