koreader / koreader-base

Base framework offering a Lua scriptable environment for creating document readers
http://koreader.rocks/
GNU Affero General Public License v3.0
130 stars 105 forks source link

Minor third-party bumps #1828

Closed NiLuJe closed 2 months ago

NiLuJe commented 2 months ago

Nothing major in LuaJIT And LPeg & LuaJSON because I noticed the lpeg update on Gentoo ;p.

I'm not even, sure we actually have anything that still uses laujson in front...


This change is Reviewable

NiLuJe commented 2 months ago

I'm not even, sure we actually have anything that still uses luajson in front...

Oh, quite a lot of stuff actually...

NiLuJe commented 2 months ago

I'm not even, sure we actually have anything that still uses luajson in front...

Oh, quite a lot of stuff actually...

And since we like shipping thirty different JSON parsers, I'll add that dksjon looks like a slightly less abandoned variant ;).

NiLuJe commented 2 months ago

And since we like shipping thirty different JSON parsers, I'll add that dksjon looks like a slightly less abandoned variant ;).

Snark aside, there's a potential cleanup opportunity to drop luajson in favor of lunajson (or, well, rapidjson even) for the few things using it in main.

(IIRC, we still need lpeg for lua-Spore, though. EDIT: Nope ^^.).

pazos commented 2 months ago

Snark aside, there's a potential cleanup opportunity to drop luajson in favor of lunajson (or, well, rapidjson even) for the few things using it in main.

Do you mean

require("json")

or yet another implementation ?

NiLuJe commented 2 months ago

Yeah, that's what tripped me up in saying we weren't using luajson anymore: I was looking for a require("luajson"), but that's indeed luajson ;).