koreader / koreader-base

Base framework offering a Lua scriptable environment for creating document readers
http://koreader.rocks/
GNU Affero General Public License v3.0
130 stars 105 forks source link

Ship openlipclua #1829

Closed NiLuJe closed 2 months ago

NiLuJe commented 2 months ago

For https://github.com/koreader/koreader/pull/12056

Pending https://github.com/notmarek/openlipclua/pull/1 so we actually have a Makefile to use ;p.


This change is Reviewable

NiLuJe commented 2 months ago

First time adding stuff to the revamped buildsystem, hoping I didn't forget anything @benoit-pierre ;).

Frenzie commented 2 months ago

I just noticed the legacy Kindle build has been failing.

openlipclua.c: In function 'check_lipc_code':
openlipclua.c:25:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
         if (code != -1) {
                  ^~
openlipclua.c: In function 'openlipcluaha_to_table':
openlipclua.c:159:21: error: a label can only be part of a statement and a declaration is not a statement
                     int data;
                     ^~~
openlipclua.c:165:21: error: a label can only be part of a statement and a declaration is not a statement
                     char* data_str;
                     ^~~~
make[2]: *** [Makefile:13: openlipclua.o] Error 1

https://gitlab.com/koreader/nightly-builds/-/jobs/7220477049

NiLuJe commented 2 months ago

Huh. I'll look into it on Monday!