make: improved binaries check/info rules - Githubissues

koreader / koreader-base

Base framework offering a Lua scriptable environment for creating document readers

http://koreader.rocks/

GNU Affero General Public License v3.0

131 stars 105 forks source link

make: improved binaries check/info rules #1866

Closed benoit-pierre closed 1 month ago

benoit-pierre commented 1 month ago

check a binary's unresolved symbols are all provided by its direct dependencies (as some dynamic loaders don't support when a symbol is provided by a transitive dependency, e.g. Android KitKat)
don't check (intermediate) libraries under build/xxx/cmake
move generated stub libraries to the staging directory (so they get cleaned with make clean)
add support for checking macOS binaries
factorize, rewrite in Python

This would have prevented https://github.com/koreader/koreader/issues/12190 & https://github.com/koreader/koreader/issues/12207, and found 3 additional issues:

djvulibre: static library need to be linked with libstdc++
djvulibre: static library need to be linker with CoreFoundation framework on macOS
czmq: must be linked with libpthread, but is not on older (<=3.25) CMake versions

This change is

benoit-pierre commented 1 month ago

PRs for czmq & djvulibre: #1867 & #1868.