search

koreader / koreader-base

Base framework offering a Lua scriptable environment for creating document readers
http://koreader.rocks/
GNU Affero General Public License v3.0
131 stars 105 forks source link

mupdf: expand list of supported CSS color names #1894

Closed benoit-pierre closed 1 month ago

benoit-pierre commented 1 month ago

Cf. https://github.com/koreader/koreader/pull/12158#issuecomment-2267492105

This change is Reviewable

ptrm commented 1 month ago

Was dictionary rendered by something else than mupdf before the big upgrade? I remember darkgray working up till then (still not tested, will try to find some time)

benoit-pierre commented 1 month ago

Not that I'm aware, no.

Frenzie commented 1 month ago

It wouldn't have worked, no. This list of colors dates back a decade to the very first implementation: https://github.com/ArtifexSoftware/mupdf/commit/bb875f77f23ac4c51a072f4fc6692ce2dc352997

Frenzie commented 1 month ago

@benoit-pierre Do you still have remaining concerns about this? It looks straightforward and obvious to me. :-)

benoit-pierre commented 1 month ago

@ptrm: where you able to confirm this fix your invisible darkgray text?