search

koreader / koreader-base

Base framework offering a Lua scriptable environment for creating document readers
http://koreader.rocks/
GNU Affero General Public License v3.0
131 stars 105 forks source link

luajit: add android luajit-launcher patch #1899

Closed benoit-pierre closed 1 month ago

benoit-pierre commented 1 month ago

Cf. https://github.com/koreader/koreader/pull/12285.

This change is Reviewable

Frenzie commented 1 month ago

I'm not entirely sure if that patch is still relevant btw. It could be it was mainly a 2.3 problem. But it's hard to test; I couldn't reproduce it myself even on 2.3.

benoit-pierre commented 1 month ago

Up until recently, I would have agreed (I've never used it on my meson branch), but I'm now having issues loading one of my test files (this animated GIF) when the patch is not applied (ARM build on my old Nexus 7). I don't know if something is getting triggered by the the newer giflib.

Frenzie commented 1 month ago

Also see this somewhat related discussion: https://github.com/koreader/koreader/issues/4137#issuecomment-410677398

NiLuJe commented 1 month ago

Oh, it is very much still relevant, the virtual address space mapping layout hasn't changed on Android AFAIK, and arm32 not being able to jump far will never change ;).

NiLuJe commented 1 month ago

Speaking of, this doesn't include the debug patch, which is really helpful in double-checking that it's behaving as expected ;).